#92 -- copy the Text objects that we're storing because I'm pretty su…

…re now we're getting hung up because Hadoop is reusing Writables so they are not safe to store in a collection
paulhoule · Dec 18, 2013 · 89cb4c6 · 89cb4c6
1 parent bfdfe11
commit 89cb4c6
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 27 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/bakemono/src/main/java/com/ontology2/bakemono/entityCentric/EntityIsAReducer.java b/bakemono/src/main/java/com/ontology2/bakemono/entityCentric/EntityIsAReducer.java
@@ -30,6 +30,11 @@ public void setup(Context context) throws IOException, InterruptedException {
             log.info("Accepting type: ["+type+"]");
     }
 
+    @Override
+    protected Text copy(Text text) {
+        return new Text(text);
+    }
+
     @Override
     protected boolean matches(Text subject, Iterable<Text> facts) {
         for(Text fact:facts) {

diff --git a/bakemono/src/main/java/com/ontology2/bakemono/entityCentric/EntityMatchesRuleReducer.java b/bakemono/src/main/java/com/ontology2/bakemono/entityCentric/EntityMatchesRuleReducer.java
@@ -23,16 +23,15 @@ protected void reduce(KEY key,Iterable<VALUE> values,Context context) throws IOE
 
         List<VALUE> rewindableValues= Lists.newArrayList();
         for(VALUE value:values) {
-            if (value.toString().contains("/m.01hpdw>")) {
-                log.info("Key: "+key+" has value ["+value+"]");
-            }
-            rewindableValues.add(value);
+            rewindableValues.add(copy(value));
         }
 
         if(matches(key,rewindableValues)) 
             for(VALUE value:rewindableValues)
                 context.write(null,value);
     }
 
+    protected abstract VALUE copy(VALUE value);
+
     protected abstract boolean matches(KEY key, Iterable<VALUE> values);
 }