Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Missing messages for ttfi and ttci #163

Merged
merged 1 commit into from
Mar 23, 2018
Merged

fix: Missing messages for ttfi and ttci #163

merged 1 commit into from
Mar 23, 2018

Conversation

GuillaumeAmat
Copy link
Contributor

It fixes a part of the #148 issue. No more errors about missing messages for ttfi and ttci.

@GuillaumeAmat GuillaumeAmat mentioned this pull request Mar 22, 2018
Closed
denar90
denar90 approved these changes Mar 22, 2018
View reviewed changes
Copy link
Collaborator

@denar90 denar90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for fixing this issue! 👍

@denar90 denar90 merged commit 00ace52 into paulirish:master Mar 23, 2018
@GuillaumeAmat
Copy link
Contributor Author

You're welcome! ✊

@GuillaumeAmat
Copy link
Contributor Author

@denar90 Do you know when the next release will be out?

@denar90
Copy link
Collaborator

denar90 commented Mar 24, 2018

I was expecting to land it with #162
Let's wait a bit, if we get no progress there I'll publish release tomorrow.
@GuillaumeAmat is it good for you?

@GuillaumeAmat
Copy link
Contributor Author

It is perfect, thanks @denar90

@GuillaumeAmat GuillaumeAmat deleted the fix/missing-ttfi-ttci-messages branch March 26, 2018 08:47
@denar90
Copy link
Collaborator

denar90 commented Mar 26, 2018

New release has been published.

@GuillaumeAmat
Copy link
Contributor Author

Thanks for the info! o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denar90 denar90 denar90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeAmat @denar90