Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rtpExtHeaderSize is a multiple of 4 #1061

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

melpon
Copy link
Contributor

@melpon melpon commented Nov 28, 2023

As defined in RFC3550, headerLength counts the number of 32-bit words. Therefore, rtpExtHeaderSize must always be a multiple of 4.

As defined in RFC3550, headerLength counts the number of 32-bit words.
Therefore, rtpExtHeaderSize must always be a multiple of 4.
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, rtpExtHeaderSize must indeed be rounded up to a multiple of 4 before creating the message. Thank you for the fix.

@paullouisageneau paullouisageneau merged commit fa3aa01 into paullouisageneau:master Nov 30, 2023
11 checks passed
paullouisageneau added a commit that referenced this pull request Jan 7, 2024
Ensure rtpExtHeaderSize is a multiple of 4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants