Refactor media handlers #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullouisageneau
force-pushed
the
refactor-media-handler
branch
from
f741196
to
d65f514
Compare
This was referenced Jul 26, 2023
Merged
paullouisageneau
force-pushed
the
refactor-media-handler
branch
2 times, most recently
from
fb1c852
to
3e3c147
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
2 times, most recently
from
f099372
to
041a248
Compare
paullouisageneau
force-pushed
the
master
branch
from
6876d98
to
9b0f18c
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
3 times, most recently
from
a4ed920
to
0dfbc8b
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
4 times, most recently
from
fe7020b
to
b472a5b
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
6 times, most recently
from
1a7b0df
to
0e4d6a4
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
2 times, most recently
from
c83ae75
to
efab23b
Compare
paullouisageneau
force-pushed
the
refactor-media-handler
branch
from
efab23b
to
db9841d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors media handlers to drastically simplify the architecture. Backward compatibility is maintained for standard usage, but user code implementing custom classes based on
MediaHandlerElementorMediaHandlerRootElementneeds to be adapted.