Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: migrate from chai to node:assert #1409

Merged
merged 1 commit into from
Jan 25, 2025
Merged

test: migrate from chai to node:assert #1409

merged 1 commit into from
Jan 25, 2025

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Jan 24, 2025

Migrates away from chai's expect assertions to node:assert.

Depends on #1408

@43081j
test: migrate from chai to node:assert
f44c202 
Migrates away from chai's `expect` assertions to `node:assert`.

Depends on #1408
@43081j 43081j marked this pull request as draft January 24, 2025 21:52
@43081j 43081j mentioned this pull request Jan 24, 2025
Merged
@paulmillr paulmillr marked this pull request as ready for review January 25, 2025 06:48
@paulmillr paulmillr merged commit 51d5cd5 into should-expect Jan 25, 2025
21 of 22 checks passed
@43081j 43081j deleted the expect-assert branch January 25, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@43081j @paulmillr