Consolidate common folders to avoid hitting the FSEvent limit #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Decide whether or not we should start a new higher-level | ||
| // parent watcher | ||
| function couldConsolidate(path) { | ||
| var candidates = {}; |
There was a problem hiding this comment.
Could you conform to our code style here please?
There was a problem hiding this comment.
Do you want the threshold variable at the top?
Also I noticed candidates is no longer being used. I'll remove that.
EDIT: Also forgot some semicolons right below that. Sorry, I don't use them so I don't even think about it. Adding 'em in.
|
Fixed style. I think, let me know if it's still not right. |
| } | ||
|
|
||
| // Find the parent of a given path | ||
| function parentOf (path) { |
There was a problem hiding this comment.
Fixed. Sorry, didn't realize that dirname worked for directories parents as well.
|
Any chance we could get a patch version bump for this so I can start using it in watchify without maintaining a fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@es128 Here's the PR for #482. Let me know if you want me to fix anything up or change it.
It does a great job on my project. Goes from 200+ instances to 19-35 (it's somewhat non-deterministic because the way the algorithm works, it depends on the order they accumulate in).