Improve ignore paths globifying

[laggingreflex]

Ensures that if only a directory's basename is provided (without the preceeding path, just dirname), it prefixes **/

Currently when only a directory name is provided, it adds a postfix /** which is great for matching the entire tree _if_ the tree is a child of the dir. So path (converted to path/**) can filter paths like path/to/file.js, but if path is actually only a directory's basename it fails to match /some/path/to/file.js. This can be solved by prefixing **/path

Really helpful when only "node_modules" is provided as ignore path (like in .gitignore file).

This could probably have solved #447, which if I followed correctly the solution ultimately was to add paths in similar patterns

    "**/.git/objects/**"
    "**/node_modules/**"

Also adjust the postfix to add just ** instead of /** based on if last char is already a /

[coveralls]

Coverage decreased (-7.8%) to 90.488% when pulling 2594dfd on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[coveralls]

Coverage decreased (-7.8%) to 90.488% when pulling 2594dfd on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[coveralls]

Coverage increased (+0.03%) to 98.314% when pulling e4aff97 on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[coveralls]

Coverage increased (+0.03%) to 98.314% when pulling e4aff97 on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[coveralls]

Coverage increased (+0.03%) to 98.314% when pulling e4aff97 on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[coveralls]

Coverage increased (+0.03%) to 98.314% when pulling e4aff97 on laggingreflex:subdir-glob into 5d56de2 on paulmillr:master.

[es128]

At a glance, this doesn't make sense to me. The relative-ness of the glob paths should match with the way the paths are specified for being watched, and that's how it's output. If you watch with absolute paths, your glob patterns need to reflect the entire absolute path and vice versa.

If something about that isn't working as expected, we can look at it and see if we can solve for the underlying cause to make sure the paths being matched reflect the same basedir as the patterns, but automatically prefixing with ** seems like an invitation for new bugs.

Maybe instead of prefixing with ** we could consider prefixing any relative ignore paths with the glob-parent basedir of the watch paths to accomplish the goal of this PR.

[laggingreflex]

You're right my bad. It seems it already works the way you described, I just needed to add cwd option.

[laggingreflex]

So just to clarify, it only excludes either when both the watch path and exclude paths are either both relative or when both are absolute. I had a watch path as an absolute path and ignored paths as relative paths. So in this case it is required to have cwd option passed in for it to work, right?

Would it be desirable to have it auto infer cwd if the watch path is absolute? Or is this intended?

[es128]

Better to think in terms of how globs are matched. The pattern path/to/*.js does not match on /some/path/to/file.js unless you first convert one or the other to be treated as absolute or relative from the same base.

Would it be desirable to have it auto infer cwd if the watch path is absolute? Or is this intended?

This is the same as the suggestion I made at the end of my comment. Might be worth it, but there might also be a risk of side effects.

In your case using cwd is one viable solution. The other is to keep the inputs consistent with each other.