Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update upath version to avoid install errors on node v10 #717

Merged
merged 1 commit into from
May 21, 2018
Merged

update upath version to avoid install errors on node v10 #717

merged 1 commit into from
May 21, 2018

Conversation

Gaafar
Copy link
Contributor

@Gaafar Gaafar commented May 17, 2018

upath versions lower than 1.0.5 fail to install on node v10

upath versions lower than 1.0.5 fail to install on node v10
@coveralls
Copy link

coveralls commented May 17, 2018

Coverage Status

Coverage remained the same at 98.502% when pulling 11aea72 on Gaafar:patch-1 into 5e75390 on paulmillr:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.502% when pulling 11aea72 on Gaafar:patch-1 into 5e75390 on paulmillr:master.

@paulmillr paulmillr merged commit 8e5d416 into paulmillr:master May 21, 2018
@kouhin
Copy link

kouhin commented Jun 18, 2018

@paulmillr We are trying to upgrade to Node.js 10 in our product. Is there any plan to ship this feature?

@paulmillr
Copy link
Owner

2.0.4 is out

chocolateboy added a commit to chocolateboy/babel-plugin-source-map-support that referenced this pull request Aug 23, 2018
error:

    error upath@1.0.2: The engine "node" is incompatible with this module.
    Expected version ">=4 <=9".

upath is required via:

    $ yarn why upath
    gulp#glob-watcher#chokidar#upath

which had an "engines" entry in its package.json which prevented it
working on node v10

1) the issue has been fixed in upath:

    anodynos/upath#15

2) chokidar has been updated to point to the updated upath:

    paulmillr/chokidar#717

3) glob-watcher has not been updated to point to the updated chokidar:

    gulpjs/glob-watcher#37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants