-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: test on macOS #154
ci: test on macOS #154
Conversation
There is no unified loader API for Node 16 and Node 22+. This fixes test compatibility with Node 16. https://stackoverflow.com/questions/78876691/syntaxerror-unexpected-identifier-assert-on-json-import-in-node-v22
I think cross platform testing makes sense for some cases:
I don’t want to test parcel, browserify etc compat inside of noble curves but it makes sense to keep doing it in eth cryptography. so, why do you think we should test builds on macos? This would just increase build times unnecessarily. Something like testing in different runtime (bun) would make more sense. |
It was motivated by this comment:
It simply seemed desired! |
ah, that was meant for eth-cryptography. do you know what we need to make curves v14-compatible? |
Maybe worth the tradeoff there, then, at least? :)
Unless I'm missing something, I think getting a new release of |
Update: It seems like this is also necessary to make the crypto module available in Node.js v14: paulmillr/noble-hashes#98 I do find it curious that this is not caught during unit tests of |
macOS-latest
Related