Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on macOS #154

Closed
wants to merge 3 commits into from
Closed

ci: test on macOS #154

wants to merge 3 commits into from

Conversation

legobeat
Copy link
Contributor

@paulmillr
Copy link
Owner

I think cross platform testing makes sense for some cases:

  1. when pkg is using underlying os api which is different accross oses (fs etc)
  2. When it’s infrastructural pkg which is getting built accross oses (ethereum-cryptography)

I don’t want to test parcel, browserify etc compat inside of noble curves but it makes sense to keep doing it in eth cryptography.

so, why do you think we should test builds on macos? This would just increase build times unnecessarily.

Something like testing in different runtime (bun) would make more sense.

@legobeat legobeat closed this Aug 29, 2024
@legobeat
Copy link
Contributor Author

legobeat commented Aug 29, 2024

so, why do you think we should test builds on macos?

It was motivated by this comment:

I don’t know how to test v14, because nodejs 14 on arm macs is unavailable.

It simply seemed desired!

@paulmillr
Copy link
Owner

ah, that was meant for eth-cryptography.

do you know what we need to make curves v14-compatible?

@legobeat
Copy link
Contributor Author

legobeat commented Aug 30, 2024

ah, that was meant for eth-cryptography.

Maybe worth the tradeoff there, then, at least? :)

do you know what we need to make curves v14-compatible?

Unless I'm missing something, I think getting a new release of @noble/hashes (I went on a limb and made an RC) into @noble/curves might be enough to do it. Happy to take a look!

@legobeat legobeat deleted the test-macos branch August 30, 2024 03:47
@legobeat
Copy link
Contributor Author

legobeat commented Aug 30, 2024

Happy to take a look!

Update: It seems like this is also necessary to make the crypto module available in Node.js v14: paulmillr/noble-hashes#98

I do find it curious that this is not caught during unit tests of @noble/hashes but it did come up when trying to use the lib in @noble/curves on Node.js v14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants