Corrects type of sign and signAsync
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only place that `priv` is used in `signAsync` and `sign` is when it is passed to `prepSig`. The only place `priv` is used in `prepSig` is when it is passed to `toPriv`. `toPriv` takes a `PrivKey`, so that means `prepSig`, `sign`, and `signAsync` can also take a `PrivKey`.
Functionally, this means that `bigint` is now allowed as a private key. This will make it so users who are storing private keys in memory as bigints will not have to first convert to hex.
Node: Currently if you naively convert your bigint private key to hex using `0x${privateKey.toString(16)}` this library will throw an error complaining about the hex for the private key being the wrong length. Arguably this library should accept an odd length hex value for the private key, but in my case just accepting bigints directly would fix the issue and allowing odd length hex strings would require an actual code change rather than just a type change.
|
What is the release process like for this project? I know it was audited, and I'm not sure if changes to type info would require a new audit or if this can be done as a patch release before the next major release? |
|
release schedule is limited once per 1-2 months unless urgent. that's mostly it. 2.0.1 will follow. |
|
also 2.0 wasn't audited, noble-curves were |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only place that
privis used insignAsyncandsignis when it is passed toprepSig. The only placeprivis used inprepSigis when it is passed totoPriv.toPrivtakes aPrivKey, so that meansprepSig,sign, andsignAsynccan also take aPrivKey.Functionally, this means that
bigintis now allowed as a private key. This will make it so users who are storing private keys in memory as bigints will not have to first convert to hex.Node: Currently if you naively convert your bigint private key to hex using
0x${privateKey.toString(16)}this library will throw an error complaining about the hex for the private key being the wrong length. Arguably this library should accept an odd length hex value for the private key, but in my case just accepting bigints directly would fix the issue and allowing odd length hex strings would require an actual code change rather than just a type change.