Merge pull request galaxyproject#19420 from ElectronicBlueberry/dupli…

…cate-subworkflows-button Enable cloning subworkflows
paulocilasjr · Jan 20, 2025 · 5f484fc · 5f484fc
2 parents 28e5f7d + 9d0ce93
commit 5f484fc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/client/src/components/Workflow/Editor/Node.test.ts b/client/src/components/Workflow/Editor/Node.test.ts
@@ -42,18 +42,17 @@ describe("Node", () => {
             },
         });
         await flushPromises();
+
         // fa-wrench is the tool icon ...
         expect(wrapper.findAll(".fa-wrench")).toHaveLength(1);
-        const toolLinks = wrapper.findAll("i");
-        expect(toolLinks.length).toBe(3);
         await wrapper.setProps({
             step: { label: "step label", type: "subworkflow", inputs: [], outputs: [], position: { top: 0, left: 0 } },
         });
+
         // fa-sitemap is the subworkflow icon ...
         expect(wrapper.findAll(".fa-sitemap")).toHaveLength(1);
         expect(wrapper.findAll(".fa-wrench")).toHaveLength(0);
-        const subworkflowLinks = wrapper.findAll("i");
-        expect(subworkflowLinks.length).toBe(2);
+
         const workflowTitle = wrapper.find(".node-title");
         expect(workflowTitle.text()).toBe("step label");
     });

diff --git a/client/src/components/Workflow/Editor/Node.vue b/client/src/components/Workflow/Editor/Node.vue
@@ -25,7 +25,7 @@
             <b-button-group class="float-right">
                 <LoadingSpan v-if="isLoading" spinner-only />
                 <b-button
-                    v-if="canClone && !readonly"
+                    v-if="!readonly"
                     v-b-tooltip.hover
                     class="node-clone py-0"
                     variant="primary"
@@ -241,7 +241,6 @@ const title = computed(() => props.step.label || props.step.name);
 const idString = computed(() => `wf-node-step-${props.id}`);
 const showRule = computed(() => props.step.inputs?.length > 0 && props.step.outputs?.length > 0);
 const iconClass = computed(() => `icon fa fa-fw ${WorkflowIcons[props.step.type]}`);
-const canClone = computed(() => props.step.type !== "subworkflow"); // Why ?
 const isEnabled = getGalaxyInstance().config.enable_tool_recommendations; // getGalaxyInstance is not reactive
 
 const isActive = computed(() => props.id === props.activeNodeId);