Light touch tests; remove old content.

fga.go

@@ -14,6 +14,7 @@ func create(ctx context.Context, tupleKey string) {
  keyParts := strings.Split(tupleKey, " ")
  if len(keyParts) != 3 {
  log.Printf("Unable to create tuple %v", tupleKey)
+ return
  }
  user := keyParts[0]
  relation := keyParts[1]
@@ -25,9 +26,7 @@ func create(ctx context.Context, tupleKey string) {
 
  if err != nil {
  log.Printf("Error writing tuple: %v", err)
- return
  }
-
 }
 
 func deleteMarked(ctx context.Context) {

fga_test.go

@@ -18,19 +18,24 @@ func (r mockRepo) GetMarkedForDeletion() []db.Tuple {
  return r.GetMarkedForDeletionFunc()
 }
 
-func (r mockRepo) CountTuples(filter *db.Filter) int {
+func (r mockRepo) CountTuples(_ *db.Filter) int {
  return 0
 }
 
 type mockFga struct {
  fgaService
+ writeFunc func(ctx context.Context, tuple *openfga.WriteRequestWrites) error
  deleteFunc func(ctx context.Context, deletes []openfga.TupleKeyWithoutCondition) (*http.Response, error)
 }
 
 func (m mockFga) delete(ctx context.Context, deletes []openfga.TupleKeyWithoutCondition) (*http.Response, error) {
  return m.deleteFunc(ctx, deletes)
 }
 
+func (m mockFga) write(ctx context.Context, tuple *openfga.WriteRequestWrites) error {
+ return m.writeFunc(ctx, tuple)
+}
+
 func Test(t *testing.T) {
 
  db.Repository = mockRepo{
@@ -47,7 +52,7 @@ func Test(t *testing.T) {
  }
  },
  }
- t.Run("Test Writes", func(t *testing.T) {
+ t.Run("Test Delete", func(t *testing.T) {
  invokedChan := make(chan interface{})
  fga = mockFga{deleteFunc: func(ctx context.Context, deletes []openfga.TupleKeyWithoutCondition) (*http.Response, error) {
  if len(deletes) == 0 {
@@ -64,4 +69,38 @@ func Test(t *testing.T) {
  <-invokedChan
  cancel()
  })
+
+ t.Run("Test Write valid tuple string", func(t *testing.T) {
+ var called = false
+ fga = mockFga{writeFunc: func(ctx context.Context, tuple *openfga.WriteRequestWrites) error {
+ if tuple == nil {
+ t.Fatal("Tuple to be written can't be null. One tuple expected")
+ }
+ called = true
+ return nil
+ }}
+ ctx, _ := context.WithTimeout(context.Background(), 3*time.Second)
+ create(ctx, "folder:zoo owner doc:turtles")
+ if !called {
+ t.Error("No write not called")
+ }
+
+ })
+
+ t.Run("Test Write invalid tuple string", func(t *testing.T) {
+ var called = false
+ fga = mockFga{writeFunc: func(ctx context.Context, tuple *openfga.WriteRequestWrites) error {
+ if tuple == nil {
+ t.Fatal("Tuple to be written can't be null. One tuple expected")
+ }
+ called = true
+ return nil
+ }}
+ ctx, _ := context.WithTimeout(context.Background(), 3*time.Second)
+ create(ctx, "folder:zoo owner h doc:turtles")
+ if called {
+ t.Error("Write should not be called for invalid tuple")
+ }
+
+ })
 }

ui.go

@@ -247,7 +247,7 @@ func AddComponents(context context.Context, app *tview.Application) *tview.Grid
  SetBorders(false).SetFixed(1, 8)
 
  tupleTable.SetFocusFunc(func() {
- helpBox.SetText("[green]CTRL-N: [white]Submit new Tuple\n[red]CTRL-D:[white] Mark tuple for [red]deletion[white]\n[blue]Control-Tab:[white] Return to the filter form")
+ helpBox.SetText("[green]<ctrl-n>: [white]Submit new Tuple\n[red]<ctrl-d>:[white] Mark tuple for [red]deletion[white]\n[blue]<ctrl-tab>:[white] Return to the filter form")
  })
  pages := tview.NewPages()
  pages.SetBorder(true)
@@ -283,7 +283,7 @@ func AddComponents(context context.Context, app *tview.Application) *tview.Grid
  SetFieldWidth(40)
 
  search.SetFocusFunc(func() {
- helpBox.SetText("[blue]ENTER:[white] triggers the filter with selected options")
+ helpBox.SetText("[blue]<enter>:[white] triggers the filter with selected options")
  })
 
  userTypes := createDropdown("User Type", "userType", db.GetUserTypes)