Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated interaction model and manifest, renamed HelloWorld intent to QuestionIntent #10

Merged
merged 9 commits into from
Dec 8, 2022

Conversation

paulotruta
Copy link
Owner

Also did a tidy up to comments and code lines that were wrongly formatted.

@paulotruta paulotruta added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 8, 2022
@paulotruta paulotruta self-assigned this Dec 8, 2022
@paulotruta paulotruta added this to the First Iteration milestone Dec 8, 2022
@@ -26,23 +26,44 @@
}
},
"manifestVersion": "1.0",
"privacyAndCompliance": {
"locales": {
"en-US": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these point to the repo?

skill.json Outdated Show resolved Hide resolved
skill.json Outdated Show resolved Hide resolved
skill.json Outdated Show resolved Hide resolved
inverse
inverse previously approved these changes Dec 8, 2022
Copy link
Collaborator

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside minor details 👍

paulotruta and others added 5 commits December 8, 2022 23:35
thank you @inverse!

Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
inverse
inverse previously approved these changes Dec 8, 2022
@paulotruta
Copy link
Owner Author

Thank you for the review @inverse! I additionally added a privacy policy and terms of use files that we can use to link in the skill manifest 👍

Will leave this PR open for some time in case some more detail comes up.

@paulotruta paulotruta requested a review from inverse December 8, 2022 22:55
Copy link
Collaborator

@inverse inverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@paulotruta paulotruta merged commit 80253b7 into main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants