-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated interaction model and manifest, renamed HelloWorld intent to QuestionIntent #10
Conversation
…t, added more info to skill manifest
@@ -26,23 +26,44 @@ | |||
} | |||
}, | |||
"manifestVersion": "1.0", | |||
"privacyAndCompliance": { | |||
"locales": { | |||
"en-US": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these point to the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside minor details 👍
thank you @inverse! Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
Co-authored-by: Malachi Soord <inverse.chi@gmail.com>
…ulotruta/jee-pee-tee into question-intent-updated-model
Thank you for the review @inverse! I additionally added a privacy policy and terms of use files that we can use to link in the skill manifest 👍 Will leave this PR open for some time in case some more detail comes up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
Also did a tidy up to comments and code lines that were wrongly formatted.