Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract client #72

Merged
merged 13 commits into from
Jan 13, 2025
Merged

Extract client #72

merged 13 commits into from
Jan 13, 2025

Conversation

inverse
Copy link
Collaborator

@inverse inverse commented Jan 11, 2025

No description provided.

Copy link
Owner

@paulotruta paulotruta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, mostly regarding the client having a different name. If you could change it to something that pertains the meaning of what it does more specifically, would be awesome 🙌 I left code change suggestions, but feel free to pick your name, or something even simpler like just "LLMClient".

Another point, is about how we pass the api client into the LLMQuestionProxy class instantiation now. I wonder if it would make sense to have a client for webhook and another one for OpenAI OpenAPI Spec compatible calls, and decide which client to pass when instantiating LLMQuestionProxy. I think at this point its ok to stay as is though, so no changes required here ;)

lambda/client.py Outdated Show resolved Hide resolved
lambda/client.py Outdated Show resolved Hide resolved
lambda/client.py Outdated Show resolved Hide resolved
lambda/lambda_function.py Outdated Show resolved Hide resolved
lambda/lambda_function.py Outdated Show resolved Hide resolved
lambda/lambda_function.py Outdated Show resolved Hide resolved
inverse and others added 7 commits January 12, 2025 12:08
Co-authored-by: Paulo Truta <pinheirotruta5@gmail.com>
Co-authored-by: Paulo Truta <pinheirotruta5@gmail.com>
Co-authored-by: Paulo Truta <pinheirotruta5@gmail.com>
@inverse
Copy link
Collaborator Author

inverse commented Jan 12, 2025

Updated with suggestions + merged main in and updated layout.

@inverse inverse merged commit a43b05a into main Jan 13, 2025
2 checks passed
@inverse inverse deleted the extract-client branch January 14, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants