Address clang-tidy warnings

paulsengroup · Oct 10, 2024 · e53f4b1 · e53f4b1
1 parent d1f4f9a
commit e53f4b1
Show file tree

Hide file tree

Showing 10 changed files with 12 additions and 12 deletions.
diff --git a/src/hictk/cli/cli_balance.cpp b/src/hictk/cli/cli_balance.cpp
@@ -424,7 +424,7 @@ void Cli::transform_args_ice_balance_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 void Cli::transform_args_scale_balance_subcommand() {
@@ -454,7 +454,7 @@ void Cli::transform_args_scale_balance_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 void Cli::transform_args_vc_balance_subcommand() {
@@ -479,7 +479,7 @@ void Cli::transform_args_vc_balance_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_convert.cpp b/src/hictk/cli/cli_convert.cpp
@@ -280,7 +280,7 @@ void Cli::transform_args_convert_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 
   if (sc.get_option("--compression-lvl")->empty()) {
     c.compression_lvl =

diff --git a/src/hictk/cli/cli_dump.cpp b/src/hictk/cli/cli_dump.cpp
@@ -222,7 +222,7 @@ void Cli::transform_args_dump_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 
   c.format = infer_input_format(c.uri);
   if (c.format == "hic" && c.resolution == 0 && c.table == "chroms") {

diff --git a/src/hictk/cli/cli_fix_mcool.cpp b/src/hictk/cli/cli_fix_mcool.cpp
@@ -159,7 +159,7 @@ void Cli::transform_args_fix_mcool_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_load.cpp b/src/hictk/cli/cli_load.cpp
@@ -273,7 +273,7 @@ void Cli::transform_args_load_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_merge.cpp b/src/hictk/cli/cli_merge.cpp
@@ -182,7 +182,7 @@ void Cli::transform_args_merge_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_metadata.cpp b/src/hictk/cli/cli_metadata.cpp
@@ -71,7 +71,7 @@ void Cli::transform_args_metadata_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_rename_chromosomes.cpp b/src/hictk/cli/cli_rename_chromosomes.cpp
@@ -100,7 +100,7 @@ void Cli::transform_args_rename_chromosomes_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 }
 
 }  // namespace hictk::tools
diff --git a/src/hictk/cli/cli_validate.cpp b/src/hictk/cli/cli_validate.cpp
@@ -69,7 +69,7 @@ void Cli::transform_args_validate_subcommand() {
   } else {
     // in spdlog, high numbers correspond to low log levels
     assert(c.verbosity > 0 && c.verbosity < 5);
-    c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+    c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
   }
 }
 

diff --git a/src/hictk/cli/cli_zoomify.cpp b/src/hictk/cli/cli_zoomify.cpp
@@ -293,7 +293,7 @@ void Cli::transform_args_zoomify_subcommand() {
 
   // in spdlog, high numbers correspond to low log levels
   assert(c.verbosity > 0 && c.verbosity < 5);
-  c.verbosity = static_cast<std::uint8_t>(spdlog::level::critical) - c.verbosity;
+  c.verbosity = static_cast<std::int16_t>(spdlog::level::critical) - c.verbosity;
 
   c.input_format = infer_input_format(c.path_to_input);
   c.output_format = infer_output_format(c.path_to_output);