Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hictk zoomify honor --no-copy-base-resolution when zoomifying .hic files #129

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Mar 4, 2024

No description provided.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 84.78%. Comparing base (44e0dd3) to head (98ca2ee).
Report is 4 commits behind head on main.

❗ Current head 98ca2ee differs from pull request most recent head a461abd. Consider uploading reports for the commit a461abd to get more accurate results

Files Patch % Lines
...k/hic/include/hictk/hic/impl/file_zoomify_impl.hpp 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   84.77%   84.78%   +0.01%     
==========================================
  Files         115      115              
  Lines        9199     9223      +24     
==========================================
+ Hits         7798     7820      +22     
- Misses       1401     1403       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit b8efada into main Mar 4, 2024
8 of 24 checks passed
@robomics robomics deleted the fix/hic-zoomify branch March 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant