Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when computing the expected value vector #147

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Apr 1, 2024

Address segfault that could occur when computing the expected value vector density for chromosomes whose size is smaller than the bin size.

Address segfault that could occur when computing the expected value
vector density for chromosomes whose size is smaller than the bin size.
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.85%. Comparing base (08d5109) to head (e433ad9).

Files Patch % Lines
...ude/hictk/impl/expected_values_aggregator_impl.hpp 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   84.86%   84.85%   -0.01%     
==========================================
  Files         117      117              
  Lines       10022    10024       +2     
==========================================
+ Hits         8505     8506       +1     
- Misses       1517     1518       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 9a703b0 into main Apr 1, 2024
54 of 56 checks passed
@robomics robomics deleted the fix/expected-values branch April 1, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant