Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to hictk zoomify #231

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Minor improvements to hictk zoomify #231

merged 3 commits into from
Aug 26, 2024

Conversation

robomics
Copy link
Contributor

The division by zero was detected while developing #217.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.85%. Comparing base (ff82e76) to head (e4d9085).
Report is 8 commits behind head on main.

Files Patch % Lines
src/hictk/cli/cli_zoomify.cpp 20.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   75.85%   75.85%           
=======================================
  Files         140      140           
  Lines       11580    11580           
  Branches     1311     1311           
=======================================
  Hits         8784     8784           
  Misses       1717     1717           
  Partials     1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit b4ebb62 into main Aug 26, 2024
52 of 53 checks passed
@robomics robomics deleted the fix/zoomify branch August 26, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant