Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to hictk validate #238

Merged
merged 8 commits into from
Sep 7, 2024
Merged

Improvements to hictk validate #238

merged 8 commits into from
Sep 7, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Aug 28, 2024

Closes #237.

@robomics robomics added the enhancement New feature or request label Aug 28, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 68.90756% with 111 lines in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (95d36fd) to head (0f0d476).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/validate/validate.cpp 68.49% 67 Missing and 19 partials ⚠️
src/hictk/include/hictk/tools/common.hpp 64.58% 10 Missing and 7 partials ⚠️
...oler/include/hictk/cooler/impl/validation_impl.hpp 65.21% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   75.50%   74.58%   -0.93%     
==========================================
  Files         140      144       +4     
  Lines       11652    12058     +406     
  Branches     1330     1384      +54     
==========================================
+ Hits         8798     8993     +195     
- Misses       1759     1947     +188     
- Partials     1095     1118      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit 2d12134 into main Sep 7, 2024
50 of 52 checks passed
@robomics robomics deleted the feat/improve-validate branch September 7, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Make output of hictk validate easier to programmatically parse
1 participant