Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compilation times #262

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Improve compilation times #262

merged 6 commits into from
Sep 28, 2024

Conversation

robomics
Copy link
Contributor

Closes #261.

@robomics robomics added enhancement New feature or request CI Updates to the Continuous Integration pipeline labels Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 68.85813% with 270 lines in your changes missing coverage. Please review.

Project coverage is 71.87%. Comparing base (af60f39) to head (534de06).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/load/pixel_parser.cpp 52.17% 37 Missing and 7 partials ⚠️
src/hictk/load/load.hpp 58.82% 24 Missing and 4 partials ⚠️
src/hictk/validate/hic.cpp 40.47% 23 Missing and 2 partials ⚠️
src/hictk/validate/cool.cpp 76.23% 22 Missing and 2 partials ⚠️
src/hictk/load/hic.cpp 72.72% 14 Missing and 4 partials ⚠️
src/hictk/load/init_bin_table.cpp 72.13% 10 Missing and 7 partials ⚠️
src/hictk/load/load.cpp 72.58% 17 Missing ⚠️
src/hictk/validate/scool.cpp 54.05% 13 Missing and 4 partials ⚠️
src/hictk/load/pixel_parser.hpp 42.85% 16 Missing ⚠️
src/hictk/validate/mcool.cpp 68.08% 11 Missing and 4 partials ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   71.93%   71.87%   -0.07%     
==========================================
  Files         147      165      +18     
  Lines       13508    13531      +23     
  Branches     1557     1546      -11     
==========================================
+ Hits         9717     9725       +8     
- Misses       2491     2516      +25     
+ Partials     1300     1290      -10     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 62.30% <73.34%> (+0.16%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/262/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 51.47% <0.00%> (-0.17%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit ad75a32 into main Sep 28, 2024
@robomics robomics deleted the fix/comp-time branch September 28, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Updates to the Continuous Integration pipeline enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[devel] reduce compilation time
1 participant