Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of ToSparseMatrix by reducing memory allocations #277

Merged
merged 11 commits into from
Oct 7, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Oct 6, 2024

No description provided.

@robomics robomics added the enhancement New feature or request label Oct 6, 2024
Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 82.19895% with 34 lines in your changes missing coverage. Please review.

Project coverage is 79.08%. Comparing base (0dafc0d) to head (e5cd665).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
.../hictk/transformers/impl/to_sparse_matrix_impl.hpp 80.89% 4 Missing and 26 partials ⚠️
...transformers/include/hictk/transformers/common.hpp 89.47% 1 Missing and 1 partial ⚠️
...e/hictk/transformers/impl/to_dense_matrix_impl.hpp 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   79.02%   79.08%   +0.06%     
==========================================
  Files         171      171              
  Lines       16324    16479     +155     
  Branches     2250     2278      +28     
==========================================
+ Hits        12900    13033     +133     
+ Misses       2455     2452       -3     
- Partials      969      994      +25     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 69.55% <ø> (+0.12%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/277/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 76.54% <82.19%> (+0.10%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit de5a6e0 into main Oct 7, 2024
123 checks passed
@robomics robomics deleted the perf/to-xxx-matrices branch October 7, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant