Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve throughput of float formatting #311

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Improve throughput of float formatting #311

merged 1 commit into from
Nov 2, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Nov 2, 2024

On my machine this gives a 4-5% performance boost when running e.g. hictk dump file.cool --normalization weight > /dev/null.

@robomics robomics added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.55%. Comparing base (f98dc1b) to head (9bca695).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   77.55%   77.55%           
=======================================
  Files         173      173           
  Lines       21225    21225           
  Branches     2310     2310           
=======================================
  Hits        16462    16462           
- Misses       3756     3757    +1     
+ Partials     1007     1006    -1     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 67.99% <ø> (-0.01%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/311/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 75.89% <ø> (+0.01%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit da6732a into main Nov 2, 2024
125 checks passed
@robomics robomics deleted the deps/tweak-fmt branch November 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant