-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wlan tuning #312
Add wlan tuning #312
Conversation
virtualguy
commented
Feb 26, 2023
- proxy_arp
- bss_transition
- fast_roaming_enabled
docs/resources/wlan.md
Outdated
@@ -62,6 +62,8 @@ resource "unifi_wlan" "wifi" { | |||
### Optional | |||
|
|||
- `ap_group_ids` (Set of String) IDs of the AP groups to use for this network. | |||
- `bss_transition` (Boolean) Enable BSS Transition Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a period to the description
docs/resources/wlan.md
Outdated
@@ -62,6 +62,8 @@ resource "unifi_wlan" "wifi" { | |||
### Optional | |||
|
|||
- `ap_group_ids` (Set of String) IDs of the AP groups to use for this network. | |||
- `bss_transition` (Boolean) Enable BSS Transition Defaults to `false`. | |||
- `fast_roaming_enabled` (Boolean) Enable Fast Roaming Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
docs/resources/wlan.md
Outdated
@@ -75,6 +77,7 @@ resource "unifi_wlan" "wifi" { | |||
- `no2ghz_oui` (Boolean) Connect high performance clients to 5 GHz only Defaults to `true`. | |||
- `passphrase` (String, Sensitive) The passphrase for the network, this is only required if `security` is not set to `open`. | |||
- `pmf_mode` (String) Enable Protected Management Frames. This cannot be disabled if using WPA 3. Valid values are `required`, `optional` and `disabled`. Defaults to `disabled`. | |||
- `proxy_arp` (Boolean) Enable Proxy ARP Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And here
go.mod
Outdated
@@ -1,4 +1,4 @@ | |||
module github.com/paultyng/terraform-provider-unifi | |||
module github.com/virtualguy/terraform-provider-unifi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated?
internal/provider/resource_wlan.go
Outdated
Description: "BSS Transition", | ||
Type: schema.TypeBool, | ||
Optional: true, | ||
Default: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should default to true to match the UI
{ | ||
Config: testAccWLANConfig_proxy_arp(subnet, vlan), | ||
Check: resource.ComposeTestCheckFunc( | ||
// testCheckNetworkExists(t, "name"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not actually checking anything here
* proxy_arp * bss_transition * fast_roaming_enabled
789736e
to
5012f34
Compare
Thanks for the clean up @joshuaspence much appreciated |
No problem, I wanted to use these changes myself! Thanks for the contribution |