Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing IP on unifi_user bug #430

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ProfMoo
Copy link

@ProfMoo ProfMoo commented Nov 30, 2023

Hi! Thanks for making this TF provider 😄.

I was trying to use this provider to get an IP address based on a known MAC address, but was getting null results back from the TF data resource. I manually checked the REST endpoint to make sure the data was available, which it was.

After some investigation, I believe an unintentional bug was introduced in this PR which overwrites the IP even if there is no local DNS record found. I have added a conditional that only overwrites the IP if there is a local DNS record instead.

I have tested this locally and it works in my scenario now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant