Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added profileUrl as a configurable url; allow to pass an object to signup endpoint #2

Merged
merged 1 commit into from
Jul 8, 2015

Conversation

vcardins
Copy link

@vcardins vcardins commented Jul 8, 2015

No description provided.

@paulvanbladel
Copy link
Owner

Ok, I see now, it's a file related to visual studio code.
No worries, we can leave that file.

@paulvanbladel paulvanbladel merged commit c3bc095 into paulvanbladel:master Jul 8, 2015
@paulvanbladel
Copy link
Owner

Victor,
Pull request merged.
Thanks a lot.

@vcardins
Copy link
Author

vcardins commented Jul 8, 2015

Excellent, Paul ! I'm glad I could help. Sorry about not mentioning the jsconfig.json file. I'll be playing with it now on and will help once I get new ideas.
Thank you for this great bit !!

@paulvanbladel
Copy link
Owner

jsconfig is fine. Code is a promising editor !
Maybe something we could look into:

I'm wondering if we can get rid of something in app.js in the sample app.
In app.js there is the activate method containing:

activate(){
    this.httpClientConfig.configure();
    this.appRouterConfig.configure();
  }

The second line is ok, and it part of the app rather than related to the aureliauth plugin.
The first line configures the httpClient and assures the token is added automatically when the client is authenticated.
I tried to find a way to do this inside the plugin rather than triggering it from the app.
Any idea?

@vcardins
Copy link
Author

vcardins commented Jul 8, 2015

I'll dig more into the codebase now on and see what I can come up with. I've implemented a httpClient wrapper for Angular2, maybe I can borrow something from.

@vcardins
Copy link
Author

Hi Paul, I'm rewriting the plugin in TypeScript and also I'll try to improve what I can. If you have other suggestions I can also help on.

@paulvanbladel
Copy link
Owner

Cool.

Functionality to ad hoc disable the inclusion of the token would be nice.

I will think about other stuff, but currently on holiday:)
Op 13-jul.-2015 12:26 schreef "Victor Cardins" notifications@github.com:

Hi Paul, I'm rewriting the plugin in TypeScript and also I'll try to
improve what I can. If you have other suggestions I can also help on.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants