-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed postgres serialisation, deserialisation of decimal #243
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes/feedback. I think the major thing is perhaps changing with_scale
to rescale
(or something similar). I do also want to run some benchmarks on this too to ensure we don't regress since it is doing a bit more boxing.
I think this is looking good. There are some minor adjustments I want to make in the docs, as well as making |
For the record, performance seems fairly consistent between the two version with this version being slightly more performant. Future performance benchmarking should be built into the PR process wherever possible. |
Fixes #241