New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Error::new in from_scientific except in error cases #350

Merged

paupino merged 1 commit into paupino:master from thomcc:from_scientific-err-new

Apr 23, 2021

Contributor

thomcc commented Apr 23, 2021

Error::new allocates a String (via str's Into impl), so there's no reason to pay this cost in the success case.


          Avoid Error::new in from_scientific except in error cases

42f553f

Owner

paupino commented Apr 23, 2021

Awesome, thanks for fixing this @thomcc

paupino merged commit 9c2a116 into paupino:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet