Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation for significant figure rounding #421

Merged
merged 3 commits into from
Aug 28, 2021
Merged

Initial implementation for significant figure rounding #421

merged 3 commits into from
Aug 28, 2021

Conversation

paupino
Copy link
Owner

@paupino paupino commented Aug 28, 2021

Resolves #389

@paupino paupino merged commit 1deccc2 into master Aug 28, 2021
@paupino paupino deleted the feature/round_sf branch August 28, 2021 02:41
@schungx
Copy link
Contributor

schungx commented Aug 28, 2021

Another round_sf_with_strategy might be useful, as for many calculations maybe we don't want to always round to even numbers?

@paupino
Copy link
Owner Author

paupino commented Aug 28, 2021

Yep, certainly possible to create a function for this behavior also - it shouldn't be too much of a lift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support rounding to significant figures instead of dp
2 participants
@paupino @schungx