Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement pow function for integer exponent. #638

Merged
merged 6 commits into from
Jan 13, 2024

Conversation

schungx
Copy link
Contributor

@schungx schungx commented Jan 13, 2024

Fixes #631 and does not become pathological with larger exponents.

@schungx
Copy link
Contributor Author

schungx commented Jan 13, 2024

For some reason, one of the tests come up with an off-by-one error at the last decimal place.

I'm not sure why but it does not show up on my computer, which passes all tests.

It could be due to the beta version being used for tests...

@paupino
Copy link
Owner

paupino commented Jan 13, 2024

It looks like it was failing when combined with the legacy-ops feature. At some stage I'll look at completing the deprecation and removing the feature (it's at least 4 years old past deprecation date). Anyway - I've gone ahead and removed the test for this feature for now.

Thank you for the PR!

@paupino paupino merged commit 80e9f08 into paupino:master Jan 13, 2024
5 checks passed
@paupino paupino mentioned this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checked_powd takes exponentially long time to complete
2 participants