Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved sorting algorithm - Automatically Infer the type of the data passed in! #4

Merged
merged 8 commits into from
Mar 13, 2017

Conversation

pavankataria
Copy link
Owner

Summary:

  • Improves the sorting algorithm for columns by scanning the data passed into the SwiftDataTable class and automatically infer the type of the data.
  • Changes Cell Row Representable to use A new DataTableValueType that moves away from the [[String]] row construction.

Technical:

  • original initialiser has been moved to a convenience one. users can still inject [[String]] into the SwiftDataTable class: [[String]].
  • Adds a new DataTableValueType.
  • Adds a string representation method for DataTableValueType.
  • Refactors Data Cell and Data CellViewModel to incorporate DataCellTypeValue 724a6f0
  • Adds a comparable implementation for DataTableValueType 29616b2 & c12ea98
  • Adds optional initialiser to DataTableValueType to automatically infer the right value type. f3d9d2c
    Improves the type detection algorithm for DataTableValueType enum b0254e8

@pavankataria pavankataria merged commit ff3db0d into master Mar 13, 2017
@pavankataria pavankataria deleted the ScanningDataType branch March 13, 2017 15:59
@pavankataria pavankataria self-assigned this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant