Update for new babbel version #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They reverted the button class to its original value today, so I updated the PR to only contain the change of the session object structure |
…ors set on the button
|
And today they changed back to the new color. It seems they switch between "primary-emphasis" and "secondary-default" regularly, breaking the button selector every time. I got fed up and changed the PR so it matches either. A selector that does not depend on the color attribute might be an option to explore. |
|
I an also a backend dev :) looks good to me, thanks for contributing! I will submit new version to google chrome extension store, should be available in a few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Babbel update 2 days ago broke the plugin: the button wasn't showing anymore. I changed the selector to match the new color class that they assigned. After that, the review items could not be read because the structure of the session object probably has changed. It seems that getting the values from the "allItems" key fixes it.
I'm a backend java developer though, so not sure about best practices or anything in javascript. Feel free to trash it and write your own solution :-)