Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewritten the Native library loader to be more flexible and testable. #25

Merged
merged 10 commits into from
Dec 22, 2022

Conversation

pavkam
Copy link
Owner

@pavkam pavkam commented Dec 22, 2022

No description provided.

@pavkam pavkam added the enhancement New feature or request label Dec 22, 2022
@pavkam pavkam self-assigned this Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 100.00% // Head: 99.96% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f07761e) compared to base (b36b0dd).
Patch coverage: 99.64% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #25      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files           33       38       +5     
  Lines         2313     2576     +263     
===========================================
+ Hits          2313     2575     +262     
- Misses           0        1       +1     
Impacted Files Coverage Δ
Sharpie/Helpers.cs 100.00% <ø> (ø)
Sharpie/Abstractions/IDotNetSystemAdapter.cs 50.00% <50.00%> (ø)
Sharpie/Backend/CursesBackend.cs 100.00% <100.00%> (ø)
Sharpie/Backend/NCursesBackend.cs 100.00% <100.00%> (ø)
Sharpie/Backend/NativeLibraryWrapper.cs 100.00% <100.00%> (ø)
Sharpie/Backend/UnixNCursesBackend.cs 100.00% <100.00%> (ø)
Sharpie/CursesInitializationException.cs 100.00% <100.00%> (ø)
Sharpie/Surface.cs 100.00% <100.00%> (ø)
Sharpie/Terminal.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pavkam pavkam merged commit 631bbdc into main Dec 22, 2022
@pavkam pavkam deleted the native-loader-work branch December 22, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant