You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi!
I am thinking how to make this plugin work out of the box with mkdocs get-deps.
Most people would probably want it to suggest markdown-exec[ansi] but it currently gives you just markdown-exec and there's no way to make it include [ansi].
Here are some things that could be done:
Just make pygments-ansi-color a default dependency of this plugin - any big reason why not?
Add a new config that people should use :
- markdown-exec:
ansi: required # one of: [off, required, auto], default: auto
(bonus compared to the current behavior: it also guards against the ansi feature silently not working - the required setting would break on missing import)
Separately, I also noticed by reading the implementation that the CSS file is currently also always included into the final site, whether or not the ansi feature was successfully enabled.
The text was updated successfully, but these errors were encountered:
No big reason why not including the extra dep by default, other than reducing deps. Option 3 would be a short term solution, but I can implement option 2 instead asap 👍
Hi!
I am thinking how to make this plugin work out of the box with
mkdocs get-deps
.Most people would probably want it to suggest
markdown-exec[ansi]
but it currently gives you justmarkdown-exec
and there's no way to make it include[ansi]
.Here are some things that could be done:
Just make
pygments-ansi-color
a default dependency of this plugin - any big reason why not?Add a new config that people should use :
(bonus compared to the current behavior: it also guards against the ansi feature silently not working - the
required
setting would break on missing import)in which case we can put this option into
extra_dependencies
in https://github.com/mkdocs/catalogSomehow just directly put
markdown-exec[ansi]
into https://github.com/mkdocs/catalogSeparately, I also noticed by reading the implementation that the CSS file is currently also always included into the final site, whether or not the ansi feature was successfully enabled.
The text was updated successfully, but these errors were encountered: