-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: output doesn't render when empty #57
Comments
Hi @awennersteen, thanks for the report! Right, I was too quick and didn't think of code blocks that are executed for sessions and also show the source. Let me fix this :) |
Thanks @pawamoy! As I said I'd be happy to implement it to save you some time, but I'd probably need a sentence or two of description of what should be the desired interface and behavior. |
Thank you so much @awennersteen, that's very kind! It's a single line change though, so I did it quickly ^^ Just pushed v1.9.2, let me know if that fixes your issue! |
Seems to have fixed it @pawamoy, thanks a lot for the quick reply |
I had the same issue. Version 1.9.2 fixes it. Thanks! |
Description of the bug
A recent PR> seems to have changed drastically the behaviour of this plugin by not rendering empty output.
Rendering such cases is useful for example when making tutorials or examples, as you can insert comments between codeblocks in a session.
Both behaviors seem very desireable though. Perhaps this can be toggleable?
An example where this affected us:
https://pasqal-io.github.io/qadence/latest/tutorials/digital_analog_qc/analog-qcl/
with source:
https://github.com/pasqal-io/qadence/blob/main/docs/tutorials/digital_analog_qc/analog-qcl.md
To Reproduce
Expected behavior
The above should render
Proposal
To keep both options is it possible to support syntax such as
I'd be happy to give this a shot an implement it but would like to know the desired direction, and perhaps some pointers to get started.
Thanks for the great plugin!
The text was updated successfully, but these errors were encountered: