Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: output doesn't render when empty #57

Closed
awennersteen opened this issue Jun 19, 2024 · 5 comments
Closed

bug: output doesn't render when empty #57

awennersteen opened this issue Jun 19, 2024 · 5 comments
Assignees

Comments

@awennersteen
Copy link

Description of the bug

A recent PR> seems to have changed drastically the behaviour of this plugin by not rendering empty output.

Rendering such cases is useful for example when making tutorials or examples, as you can insert comments between codeblocks in a session.

Both behaviors seem very desireable though. Perhaps this can be toggleable?

An example where this affected us:

https://pasqal-io.github.io/qadence/latest/tutorials/digital_analog_qc/analog-qcl/
with source:
https://github.com/pasqal-io/qadence/blob/main/docs/tutorials/digital_analog_qc/analog-qcl.md

To Reproduce

a=1+1

Expected behavior

The above should render

Proposal

To keep both options is it possible to support syntax such as

a=1+1

I'd be happy to give this a shot an implement it but would like to know the desired direction, and perhaps some pointers to get started.

Thanks for the great plugin!

@awennersteen awennersteen changed the title bug: bug: output doesn't render when empty Jun 19, 2024
@pawamoy
Copy link
Owner

pawamoy commented Jun 19, 2024

Hi @awennersteen, thanks for the report!

Right, I was too quick and didn't think of code blocks that are executed for sessions and also show the source. Let me fix this :)

@awennersteen
Copy link
Author

Thanks @pawamoy!
Impossible to consider all use-cases in advance

As I said I'd be happy to implement it to save you some time, but I'd probably need a sentence or two of description of what should be the desired interface and behavior.
Whatever is the easiest for you :)

pawamoy added a commit that referenced this issue Jun 20, 2024
@pawamoy
Copy link
Owner

pawamoy commented Jun 20, 2024

Thank you so much @awennersteen, that's very kind! It's a single line change though, so I did it quickly ^^ Just pushed v1.9.2, let me know if that fixes your issue!

@jpmoutinho
Copy link

Seems to have fixed it @pawamoy, thanks a lot for the quick reply

@tylerh111
Copy link

I had the same issue. Version 1.9.2 fixes it. Thanks!

@pawamoy pawamoy closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants