Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag page: add / to "all tags" link #60

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

heitorPB
Copy link
Contributor

@heitorPB heitorPB commented Mar 5, 2024

This is to improve Google indexing pages, for the /tags/ page. In GitHub Pages, the URL /tags does not exist per se, but is a redirect to /tags/. Google Crawler gets confused with 301 HTTP status and does not index it.

Purely for SEO purposes.

This is to improve Google indexing pages, for the /tags/ page. In GitHub
Pages, the URL /tags does not exist per se, but is a redirect to /tags/.
Google Crawler gets confused with 301 HTTP status and does not index it.
@pawroman
Copy link
Owner

pawroman commented Jun 5, 2024

Hmm, should we add a trailing slash to all URLs then? I see similar behavior on GitLab pages. If this is added anyway, we can avoid one round trip by adding / to all the links in the top navigation pane by default.

@pawroman pawroman added the help wanted Extra attention is needed label Jun 5, 2024
@heitorPB
Copy link
Contributor Author

heitorPB commented Jun 5, 2024

That could lead to double trailing slashes?

I only found this issue on the tags page, did you find it in other places as well?

@pawroman
Copy link
Owner

pawroman commented Jun 6, 2024

Huh. Looks like I misunderstood the problem.

Are we talking about this link specifically? See screenshot below and the source URL.

https://pawroman.github.io/zola-theme-terminimal/tags/javascript/
image

@heitorPB
Copy link
Contributor Author

heitorPB commented Jun 6, 2024

Yes, that link.

Is there a missing / in other links as well? Not sure I got your point.

@pawroman pawroman merged commit c620187 into pawroman:master Jun 7, 2024
@pawroman
Copy link
Owner

pawroman commented Jun 7, 2024

For a moment I thought that github/gitlab were doing some URL manipulation when the website got deployed, but then I realized that all the URLs come from the theme.

So your fix makes sense, to make things consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants