Add support for comments via utterances #65
Conversation
| @@ -1,3 +1,8 @@ | |||
| html { | |||
| /* Base font size */ | |||
| font-size: 16px; | |||
There was a problem hiding this comment.
Added an explicit base font size since everything else uses rem, it was already implicitly 16px.
| @@ -29,8 +29,6 @@ body { | |||
| } | |||
|
|
|||
| h1, h2, h3, h4, h5, h6 { | |||
| display: flex; | |||
| align-items: center; | |||
| font-weight: bold; | |||
There was a problem hiding this comment.
display: flex breaks how inline code blocks are rendered in headings, so I removed it.
| @@ -118,7 +116,6 @@ figure { | |||
| } | |||
|
|
|||
| code { | |||
| font-family: Hack, DejaVu Sans Mono, Monaco, Consolas, Ubuntu Mono, monospace; | |||
There was a problem hiding this comment.
Moved the font family to the font file.
There was a problem hiding this comment.
Hmmm, I don't see this font-family anywhere now. Are you sure it won't break things?
There was a problem hiding this comment.
It's defined here. I've tested the changes locally but it doesn't hurt if you give it a try to sanity check.
|
|
||
| &__title { | ||
| display: flex; | ||
| text-align: center; | ||
| position: relative; | ||
| margin: 100px 0 20px; | ||
| margin: 25px 0 20px; | ||
|
|
There was a problem hiding this comment.
I adjusted the spacing between the comments and pagination sections so it looked nicer.
There was a problem hiding this comment.
Hey, thanks for the contribution! TIL about utterances. Quite cool!
Please address the comments, as well as my comment from other PR about the TOC #68 (comment) -- because it also applies here.
After the outstanding comments are resolved, I'll need to review it again for visual changes. But overall looks good!
| @@ -118,7 +116,6 @@ figure { | |||
| } | |||
|
|
|||
| code { | |||
| font-family: Hack, DejaVu Sans Mono, Monaco, Consolas, Ubuntu Mono, monospace; | |||
There was a problem hiding this comment.
Hmmm, I don't see this font-family anywhere now. Are you sure it won't break things?
|
@pawroman Sorry to ping you, but I think I've addressed your comments. Mind taking a look? |
Hi there,
This PR adds support for comments via utterances.
Demo