Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement internal math module #114

Merged
merged 10 commits into from
Feb 17, 2024
Merged

Implement internal math module #114

merged 10 commits into from
Feb 17, 2024

Conversation

samuelselleck
Copy link
Contributor

This implements an internal math module, to be exposed to users of pax, and removes the use of kurbo::Affine as the engines main transform type.

Copy link
Member

@zackbrown zackbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! Small changes requested re: design_utils, per team conversation. After that, please go ahead and merge directly.

pax-engine/src/lib.rs Outdated Show resolved Hide resolved
pax-runtime/src/engine/design_utils.rs Outdated Show resolved Hide resolved
pax-runtime/src/engine/mod.rs Outdated Show resolved Hide resolved
@samuelselleck
Copy link
Contributor Author

This is done now!

  • Created a new NodeInterface type that is a public wrapper over ExpandedNode
  • Added methods on NodeContext to do raycasting, finding by id, etc (forwarding calls to render_context and wrapping results in NodeInterface)
  • Renamed NodeContext to EngineContext to better reflect it's ability to do things like global raycasting

@warfaj
Copy link
Member

warfaj commented Feb 17, 2024

LGTM! Thanks for the changes.

@warfaj warfaj merged commit b02f367 into master Feb 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants