Add property to focus textbox on mount #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warfaj
requested changes
Mar 2, 2024
| @@ -276,6 +276,10 @@ export class NativeElementPool { | |||
| if (patch.transform != null) { | |||
| leaf.style.transform = packAffineCoeffsIntoMatrix3DString(patch.transform); | |||
| } | |||
|
|
|||
| if (patch.focus_on_mount) { | |||
| setTimeout(() => { textbox.focus(); console.log("focused!"); }, 10); | |||
There was a problem hiding this comment.
any reason we set a timeout here rather than just call textbox.focus()?
also we can remove the console.log
There was a problem hiding this comment.
Oops, Removed log!
Didn't focus correctly for some reason without it, not exactly sure why. It should have been added to the dom already? (requirement for focus to work). I just took the fast path :)
There was a problem hiding this comment.
cool that sounds good. We can figure out later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus_on_mount={true/false}