Some nits for Pax lsp #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey just merged the major changes for language server. It looks like there are a few merge conflicts. Could you take another pass to see if it changes your refactoring. |
ouz-a
force-pushed
the
some_lsp_things
branch
from
961603f to
f35c095
Compare
ouz-a
force-pushed
the
some_lsp_things
branch
from
f35c095 to
d4260ea
Compare
ouz-a
force-pushed
the
some_lsp_things
branch
from
d4260ea to
82ba120
Compare
|
resolved conflicts and went trough some changes again. |
Can you run this locally with the vscode extensionand verify that it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I quite like how simple this code is just added added small touches here and there.
r? @warfaj