Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sync Stripe Credit Balance to Pay::Customer #825

Merged
merged 7 commits into from
Jul 18, 2023
Merged

feat: Sync Stripe Credit Balance to Pay::Customer #825

merged 7 commits into from
Jul 18, 2023

Conversation

nachiket87
Copy link
Contributor

fixes #789

First time contributing to this repo. ❤️

@nachiket87 nachiket87 force-pushed the add-invoice-credit-balance branch from 22c6a80 to f16b51b Compare June 6, 2023 01:46
@excid3
Copy link
Collaborator

excid3 commented Jun 6, 2023

This is a great start @nachiket87 👍

I think we'll want to store this in the Pay::Customer object and keep it synced using the customer.updated webhook. This way we can have it in the database always and keep it in sync with what's in Stripe (like when someone manually applies credit to a customer in their dashboard).

@nachiket87
Copy link
Contributor Author

This is a great start @nachiket87 👍

I think we'll want to store this in the Pay::Customer object and keep it synced using the customer.updated webhook. This way we can have it in the database always and keep it in sync with what's in Stripe (like when someone manually applies credit to a customer in their dashboard).

ah yes I see now! I'll make the changes tomorrow. Thanks for the feedback!

@nachiket87
Copy link
Contributor Author

Hey @excid3 I've updated the PR with the new changes. If you get a minute, please could you take a look. Thanks!

cjilbert504 and others added 2 commits June 19, 2023 14:16
@cjilbert504
rename payment_customer to stripe_customer
6f453bb 
Renaming variable to better reflect the actual underlying object being used in the code.
@nachiket87
test(vcr): add updated vcr cassettes
690d5b5
@nachiket87
Copy link
Contributor Author

Thanks for the refactor @cjilbert504!

@excid3 excid3 merged commit 275d512 into pay-rails:master Jul 18, 2023
@excid3
Copy link
Collaborator

excid3 commented Jul 18, 2023

Huge thanks @nachiket87! This is going to be really handy to have.

@nachiket87
Copy link
Contributor Author

Thank you @excid3 got taking the time to review and merge and @cjilbert504 for the reviews and suggestions

@cjilbert504
Copy link
Collaborator

@nachiket87 - Thanks a bunch for this one! Nice work

@excid3
Copy link
Collaborator

excid3 commented Jul 18, 2023

Just cut the new release 6.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excid3 excid3 excid3 left review comments

@cjilbert504 cjilbert504 cjilbert504 left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync Stripe Credit Balance to Pay::Customer
3 participants
@nachiket87 @excid3 @cjilbert504