Fix to Paddle Billing Payment Method creation #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any movement on getting this merged? Also just hit this problem (thanks for having already prepared the fix though!) |
|
+1 for having this merged if possible |
excid3
reviewed
May 14, 2024
|
We should update tests for this, but I'm going to merge this anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found in this discussion: #922 (comment)
It also adds a new method called
sync_from_transactionwhich takes both apay_customerand atransaction. This then uses the Paddle API to grab the details for that transaction and create/update a Payment Method for the given Pay Customer.