Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAYARA-3119 NullPointerException when starting Jersey/EJB Containers in Order #3209

Merged
merged 1 commit into from
Sep 28, 2018
Merged

PAYARA-3119 NullPointerException when starting Jersey/EJB Containers in Order #3209

merged 1 commit into from
Sep 28, 2018

Conversation

jGauravGupta
Copy link
Contributor

@jGauravGupta jGauravGupta commented Sep 27, 2018

@jGauravGupta
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@MeroRai MeroRai merged commit 7494a1e into payara:master Sep 28, 2018
Copy link
Contributor

@smillidge smillidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what is the performance impact of adding synchronized to this code on deployment of large EAR files?

@payara-ci
Copy link
Contributor

Quick build and test passed!

@jGauravGupta
Copy link
Contributor Author

Locking is added on EJB container instance and interceptor registered synchronously from Jersey (or other modules) ComponentProvider during EJB Container start phase. So it should not have impact on performance.

MarkWareham pushed a commit to MarkWareham/Payara that referenced this pull request Oct 25, 2018
PAYARA-3119 NullPointerException when starting Jersey/EJB Containers in Order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants