CUSTCOM-174 Avoid NPE by EJBException.addSuppressed()

[rdebusscher]

CUSTCOM-174 Avoid NPE by EJBException.addSuppressed() by ContainerTransactionManager.

Description

This is a bug fix

EJBException.addSuppressed() will throw a NPE when called with a null parameter. The code within
ContainerTransactionManager doesn't check for this condition and user encountered this problem due to changes done in 5.194 release (#4325)

Testing

New tests

No unit test created due to some final methods which cannot be mocked.

Test suites executed

• Quicklook

Testing Environment

Oracle 1.8.0_181 on Mac 10.14.6 with Maven 3.5.4

[dmatej]

Aha, I see it, line 634 inv.exception can be null, mea culpa! The indirect evidence is in BaseContainer ... the doTxProcessing may be true, as it is parameter ...

        if ( inv.ejb != null ) {
            // counterpart of invocationManager.preInvoke
            if (! inv.useFastPath) {
                invocationManager.postInvoke(inv);
                delistExtendedEntityManagers(inv.context);
            } else {
                doTxProcessing = doTxProcessing && (inv.exception != null);
            }

            try {
                if ( doTxProcessing ) {
                    postInvokeTx(inv);
                }

[dmatej]

Jenkins test please