Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUSTCOM-22 Upgrade Grizzly and Amend HTTP/2 Push Help Text #4669

Merged
merged 3 commits into from
Jun 2, 2020
Merged

CUSTCOM-22 Upgrade Grizzly and Amend HTTP/2 Push Help Text #4669

merged 3 commits into from
Jun 2, 2020

Conversation

MattGill98
Copy link
Contributor

Description

HTTP/2 push contains several problems (see #2625). Even when HTTP/2 push was disabled, these errors would occur which this PR prevents. Note that this PR doesn't fix the HTTP/2 push problems, but should prevent the Unable to push resource identified by path errors in the logs.

Important Info

Blockers

Patched artifact: payara/Payara_PatchedProjects#308

Overrides PR: #4654

Testing

Testing Performed

Quickly hard reload the index page (CTRL + F5) for the app found here: https://bitbucket.org/luminositylabs/payara-2625.git

Testing Environment

Zulu JDK 1.8u242 (must be no later than 8u250). See CUSTCOM-259 for why.

Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
The help text in the admin console for HTTP/2 push status read with an
incorrect default value.

Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
@MattGill98 MattGill98 requested review from Cousjava and MeroRai May 14, 2020 11:06
@MattGill98 MattGill98 self-assigned this May 14, 2020
@MeroRai
Copy link
Member

MeroRai commented May 18, 2020

Jenkins test please

1 similar comment
@MeroRai
Copy link
Member

MeroRai commented May 18, 2020

Jenkins test please

@MattGill98
Copy link
Contributor Author

jenkins test please

1 similar comment
@MattGill98
Copy link
Contributor Author

jenkins test please

@MattGill98
Copy link
Contributor Author

jenkins test please

1 similar comment
@MattGill98
Copy link
Contributor Author

jenkins test please

@MattGill98 MattGill98 merged commit f8679df into payara:master Jun 2, 2020
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Jun 15, 2020
CUSTCOM-22 Upgrade Grizzly and Amend HTTP/2 Push Help Text
 Conflicts:
	pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants