QACI-242 Payara Samples Tests Are Attempting to Run Micro Tests for Remote Profile #4692
Conversation
|
|
||
| <profiles> | ||
| <profile> | ||
| <id>payara-server-remote</id> |
There was a problem hiding this comment.
Samples is only run against remote so shouldn't need to have a separate profile for this - just in default
There was a problem hiding this comment.
Isn't the default profile managed?
There was a problem hiding this comment.
Maybe in the poms but we only run samples on remote
There was a problem hiding this comment.
Yes, it would be imprudent to assume that will always be the case though
There was a problem hiding this comment.
I completely understand what you mean though 😀
There was a problem hiding this comment.
going forward it needs to be run over all profiles
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <excludes> | ||
| <exclude>${exclude.tests}</exclude> |
There was a problem hiding this comment.
Exclude explicitly rather than using a property? Or possibly exclude the module from the list of included modules if that's how the project is set up
There was a problem hiding this comment.
We want the tests to run when not using remote profile
There was a problem hiding this comment.
I could exclude the module instead, but I dont think its neccessery
The mvn command I used is the one jenkins uses, which is where we had the problems, which is why it might not make much sense.
|
|
It is the reason why those "programmatical" tests are separated from "profiled" tests. Now you created a profile with the same name in "programmatical" build branch where those profiles intentionally don't exist. |
|
Should we be changing the jenkins command for samples in that case then? Rather than the test profiles |
|
From what David's saying, yes |
|
jenkins test please |
|
Approving too, despite too late ;) |
QACI-242 Payara Samples Tests Are Attempting to Run Micro Tests for Remote Profile
Description
Quick fix to stop micro tests on running on remote profile
Testing
Testing Performed
Tested and passed locally
Ran maven clean install;
mvn -V -B -fae help:active-profiles clean install -f appserver/tests/payara-samples -Dpayara.version=5.2020.2-SNAPSHOT -Dpayara_domain=test-domain -Dglassfish.home=/home/alanroth/Workspace/Payara/appserver/distributions/payara/target/stage/payara5 -Ppayara-server-remoteTesting Environment
Openjdk 11.0.7
Ubuntu 64 bit
Maven 3.6.3
Notes for Reviewers
This isn't designed to be a permanent solution, origionally planned on having a annotation like 'NotMicroCompatible' but for remote, 'NotRemoteCompatible'