FISH-5801: Custom Vendor MP Metrics Using Placeholders Require 'tags' #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test please |
aubi
reviewed
Nov 1, 2021
| for (XmlTag tag: tags) { | ||
| if (tag.getValue().contains(keyword)) { | ||
| tagSpecifier = true; | ||
| if (tags != null) { |
There was a problem hiding this comment.
tags can never be null, was fixed by FISH-5658
aubi
approved these changes
Nov 2, 2021
|
jenkins test please |
Pandrex247
approved these changes
Nov 4, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Nov 18, 2021
FISH-5801: Custom Vendor MP Metrics Using Placeholders Require 'tags'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Exception when not using tags in custom Vendor metrics having a Placeholder.
Important Info
Testing
New tests
new Unit test MBeanMetadataTest
Testing Environment
Zulu 8.52.0.23-CA-macosx (build 1.8.0_282-b08) on Mac 11.8 with Maven 3.8.2
Documentation
Not needed, Bugfix