-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: make Arquillian Remote connector address and port configurable / FISH-7052 #66
Enhancement: make Arquillian Remote connector address and port configurable / FISH-7052 #66
Comments
I am willing and able to create a pull request for this. Please let me know what you think. If you are interested, what would be an ETA for reviewing and accepting the PR as well as cutting a new release? @kiview this might be of interest for you 😄 |
Hi @poikilotherm, I would strongly recommend making a PR for this enhancement as you said you are willing and able to, we would much appreciate your contribution and will greatly speed up the time to get this enhancement available for you. While we can't provide an exact ETA, after a PR has been created a member of our engineering team will aim to have this reviewed and released shortly after. Thanks, |
Hi @JamesHillyard, thanks for coming back to me. I just created payara/ecosystem-arquillian-connectors#214. Crossing fingers this gets merged and released soon! 🤞 |
Hi @poikilotherm, Thank you very much for creating a PR to address this, I have raised the internal issue Best Regards, |
Brief Summary
When using Testcontainers to create a Payara deployment, I need to map port 8080 and 4848 to some random number assigned by Testcontainers. This is non-changeable in Testcontainers. Instead of hardwiring to read address and port from remote server, make it also overrideable via Arquillian configuration.
Expected Outcome
Enable configuration in
arquillian.xml
:Either enable
CommonPayaraConfiguration
to save the additional infos, being used inPayaraClientService
to built the URLs or create an extended configuration, following the schema ofPayaraMicroRemoteContainerConfiguration
andPayaraMicroRemoteDeployableContainer
.Current Outcome
Within
PayaraClientService#L337
the address and port are hardcoded to be retrieved from the remote end.Arquillian cannot reach the servlet as a result - the random port
32790
is not transfered:Context
This works with Wildfly. Used this in a related experiment.
Ecosystem Tool
Arquillian Connectors
The text was updated successfully, but these errors were encountered: