FISH-7052 remote adapter config host #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything else is 2.6-SNAPSHOT, so probably some artifact from a release. Was necessary to test properly.
…vice By adding the RemoteInstanceConnectionProvider interface, a configuration that implements this provider can override the host and port information read from the servers configuration via the admin API of Payara. Using this interface also avoids adding a direct dependency onto an underlying adapter.
Adding a special configuration (as already seen at the other adapter) for remote instances allows us to make Arquillian inject the httpPort and httpHost properties. As the config implements RemoteInstanceConfigurationProvider, the information can be retrieved from the Payara client.
JamesHillyard
changed the title
|
Hello @JamesHillyard it's been a while... Could someone pretty please take a look at this? Thank you very much! |
jGauravGupta
approved these changes
Apr 18, 2023
|
Thanks @jGauravGupta for looking into this and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes payara/ecosystem-support#66
Hi there!
This pull request enables to override the HTTP host and HTTP port information for a remote instance via
arquillian.xml:This way, I can supply host and port information from @testcontainers to the Payara Arquillian Remote Adapter, enabling the usage of Testcontainers to provide a deploy target for Arquillian.
Thanks for reviewing (and merging)! ❤️
I tested this with Dataverse as part of IQSS/dataverse#7424 (the code is not yet pushed, as I need to use the snapshot builds of the connectors). Works flawless for me! 😄