FISH-7052 [Community Contribution] Arquillian Remote Connector Make Address and Port Configurable #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything else is 2.6-SNAPSHOT, so probably some artifact from a release. Was necessary to test properly.
…vice By adding the RemoteInstanceConnectionProvider interface, a configuration that implements this provider can override the host and port information read from the servers configuration via the admin API of Payara. Using this interface also avoids adding a direct dependency onto an underlying adapter.
Adding a special configuration (as already seen at the other adapter) for remote instances allows us to make Arquillian inject the httpPort and httpHost properties. As the config implements RemoteInstanceConfigurationProvider, the information can be retrieved from the Payara client.
jGauravGupta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #214