Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-3031 Fix HTTP/2 Trailer Issue #13

Merged
merged 4 commits into from
Nov 10, 2018
Merged

PAYARA-3031 Fix HTTP/2 Trailer Issue #13

merged 4 commits into from
Nov 10, 2018

Conversation

MattGill98
Copy link

  • Fixes h2spec issue where local window size is used instead of peer frame size.
  • Add trailer frames to output queue instead of sending immediately. This forces Grizzly to wait until all the data is sent before sending the final trailers.

As far as I can tell the issue is fixed and all the h2spec tests still pass. Needs a full review though, as this is probably the most disruptive change I've made to date.

@MattGill98 MattGill98 self-assigned this Aug 20, 2018
@MattGill98 MattGill98 requested a review from lprimak August 20, 2018 15:32
@lprimak
Copy link

lprimak commented Aug 22, 2018

Hmm, this one I will have to check out and look at further...

@MattGill98 MattGill98 mentioned this pull request Sep 28, 2018
Closed
@arjantijms arjantijms merged commit 79c0214 into payara:2.4.3.payara-maintenance Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lprimak lprimak lprimak approved these changes

Assignees

@MattGill98 MattGill98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattGill98 @lprimak @arjantijms